Provide abstract Soap client builder and client even if no clients are configured and add composer.json#21
Open
ddeboer wants to merge 7 commits intoBeSimple:masterfrom
Open
Provide abstract Soap client builder and client even if no clients are configured and add composer.json#21ddeboer wants to merge 7 commits intoBeSimple:masterfrom
ddeboer wants to merge 7 commits intoBeSimple:masterfrom
Conversation
|
+1, I suggest to add too the minOccurs in SoapParam annotation, and the maxOccurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even if no clients are configured in
config.yml, it makes sense to have thebesimple.soap.client.builderandbesimple.soap.clientservices available. This way, other Symfony2 bundles can configure theirservices.xmlto provide and use their own BeSimple SOAP clients based on the abstract services.